Mixed support #2409

kchobantonov · 2024-12-30T07:41:14Z

provide support for mixed types
fix clearing of inputs when not under an object - e.g. string once cleared will become empty string rather than to return undefined to remove the property from the parent object
fix date controls, now the date can show year, year/month and etc. depending on the control option views
improve the performance to convert dayjs format into maska format function
fixing the :key to at least have the collection size into the key so when the size changes the vue will not reuse html elements leaving attributes like id unchanged
add more examples to show how the mixed control can be used
use arraySchema from the mapped values rather than using Resolve
minor UI changes to use less space
core changes : use the provided schema when the resolve failed, make sure that boolean is valid schema as well - e.g. items: true is valid schema (Note: the last change for the items to be boolean was reverted back since more code should be adjusted - maybe a future improvement)
introduce a new config - allowAdditionalPropertiesIfMissing - this allows to show the additioanalProperties UI when the additionalProperties and patternProperties do not exist. The reason is that by default if the additionalProperties is missing from the schema the default should be considered as true but the UI component does not respect that default - e.g. it needs to be explicitly states as additionalProperties: true if the UI control is needed without the allowAdditionalPropertiesIfMissing config

…ot part of the object that has the property defined in properties then to not clear it - e.g. send undefined value

…tions.views

… based on index - e.g. prevent reusing elements when the array change size which will cause id properties for example to not have correct value

…tified for the new value

…ke so much space

…er the Group

…n also allow such case to be handled by the object renderer

…s no need to resolve that schema just use it

…n the mixed renderer selected object type

kchobantonov · 2025-02-13T23:32:56Z

@sdirix check my responses and also updated repo but it looks like the build failed perhaps because netlify is using greater than pnpm version 8 now ?

sdirix

I have concerns about the proposed changes to the core functionality.

Please have a look at my new comments and the unresolved comments from my previous review.

packages/core/src/mappers/renderer.ts

packages/core/src/util/resolvers.ts

packages/vue-vuetify/src/complex/AllOfRenderer.vue

packages/vue-vuetify/src/complex/MixedRenderer.entry.ts

…d renderer handle the true value directly

kchobantonov · 2025-05-08T10:09:48Z

@sdirix please review again - here are the outstanding items that I need to check with you if you are ok with those as they are at the moment with the explanation that was provided.

change in the packages/core/src/util/resolvers.ts - I have added the reason why is that but I haven't yet resolved the conversation
the changes to the :key to include the size of the layout items is still there at least until there is some support from the core to know when the uischema is changes to use the proper key that will work on all changes to the layout data - e.g. reordering and etc.
the issue where when we want to clear an input that is part of the additionalProperties (e.g. dynamic) and the type is an enum that we use an empty string as a reset value - not sure at the moment how to handle that one with a valid enum value since clearing does not necessary means to select any of the valid values from the supported enum set. Before that this change was not needed but then we were having an issue when we wanted to set the JSON as a data and that to be reflected by the UI - e.g. removing a dynamic field from the JSON and applying that to the form was not having an effect - that is why this change with what to set the value when the control clears the value was needed

… and we have patternProprties

packages/vue/src/components/JsonForms.vue

sdirix

Works good for me!

I'm waiting on Lucas' (or your) input to this suggestion and the handling of the additionalErrors. When they are resolved I'm happy to merge.

Thanks for your great work and patience ;)

Nitpick: the "Mixed" and "Json Editor" examples in the Vue Vuetify app do not render as nicely as the other examples. Does not need to be resolved for the merge.

sdirix · 2025-05-21T09:02:48Z

@kchobantonov Please adapt the resolver as suggested and the additionalErrors, then we can merge

kchobantonov · 2025-05-22T12:47:54Z

@sdirix both changes that were request are now done - please review again and let me know if anything else is needed. Thanks for your feedback.

packages/core/src/util/resolvers.ts

packages/vue/src/types.ts

Co-authored-by: Stefan Dirix <sdirix@eclipsesource.com>

…ctly

kchobantonov · 2025-05-22T15:24:35Z

@sdirix please review again - all concerns should be addresses and the last commit is fixing an issue where in the jsonschema example when you try to add new example field as an object and you do enable from the "Allow Additional Properties By Default" option then to correctly determine the type of the new properties that are going to be added to this new object example.

kchobantonov added 30 commits December 29, 2024 03:07

initial mixed renderer support

f8c2caf

organize imports

c078710

handle correctly the clear where if the property that is cleared in n…

ece92ac

…ot part of the object that has the property defined in properties then to not clear it - e.g. send undefined value

update controls to properly send clear value

bd28667

update control to properly send clear value and add support for UI op…

a62efb4

…tions.views

optimize the performance of convertDayjsToMaskaFormat function

4bc6b73

fix key property where the value is not based on data primary key but…

4716a43

… based on index - e.g. prevent reusing elements when the array change size which will cause id properties for example to not have correct value

organize imports

807546f

add translations

25300db

make sure that we use new date so that the proxyModel is correctly no…

81c81db

…tified for the new value

no need to check props?.schema?.properties

3a4f2b9

proper implementation for the optional translator

6b5dca8

change the way how we determine if default value should be returned

2f96aef

use control.arraySchema instead of Resolve

cc44091

use control.arraySchema instead of Resolve, make the header to not ta…

d460e6c

…ke so much space

clean up class

1f24b21

use less space

d716953

do not render the div if nothing to renders as children

498cbf1

use more descriptive name

72e17d0

if we are in dynamic context then always prefer the VerticalLayout ov…

89bfb0b

…er the Group

if the schema is an object that is selected because of mixed type the…

ef24610

…n also allow such case to be handled by the object renderer

when the mixed renderer provides the exact schema to use then there i…

492e5fd

…s no need to resolve that schema just use it

add core schema meta-schema as example

434a1f9

Merge branch 'master' into mixed-support

532fa9f

resolve schema like 'items': true

22760af

add jsonschema example

8a1b523

symplify how we determine that the object renderer should be used whe…

1d51ee8

…n the mixed renderer selected object type

items in draft7 can accept boolean

770531a

add generic json editor example

6ead876

fix items.type

b7460ab

Merge branch 'master' into mixed-support

1c146bd

kchobantonov and others added 3 commits February 13, 2025 18:44

remove prop

fd7efb4

Merge branch 'master' into mixed-support

0e1577b

Merge branch 'master' into mixed-support

6b863d9

sdirix reviewed Mar 24, 2025

View reviewed changes

kchobantonov added 3 commits May 5, 2025 17:15

remove changing the schema from true to mixed types and make the mixe…

ad8f056

…d renderer handle the true value directly

update mixed renderer and remove changes in the core to support it

d05642a

Merge branch 'master' into mixed-support

3d632b7

kchobantonov requested a review from sdirix May 8, 2025 10:04

kchobantonov and others added 4 commits May 8, 2025 14:13

expand the property name check when the additionalProperties is false…

82fb3be

… and we have patternProprties

Merge branch 'master' into mixed-support

33e451c

add additionalErrors into the event

8f862d7

Merge branch 'master' into mixed-support

85aefe7

sdirix reviewed May 20, 2025

View reviewed changes

packages/vue/src/components/JsonForms.vue Outdated Show resolved Hide resolved

sdirix reviewed May 20, 2025

View reviewed changes

kchobantonov added 2 commits May 22, 2025 08:37

revert adding the additionalErrors

06e4fbf

use the suggested fix

d41b83c

kchobantonov requested review from sdirix and lucas-koehler May 22, 2025 12:48

sdirix reviewed May 22, 2025

View reviewed changes

packages/core/src/util/resolvers.ts Outdated Show resolved Hide resolved

sdirix reviewed May 22, 2025

View reviewed changes

packages/vue/src/types.ts Outdated Show resolved Hide resolved

kchobantonov and others added 2 commits May 22, 2025 09:08

remove additionalErrors

90cb85a

Update packages/core/src/util/resolvers.ts

45c3464

Co-authored-by: Stefan Dirix <sdirix@eclipsesource.com>

kchobantonov requested a review from sdirix May 22, 2025 13:10

make the JsonSchema example when adding new Example object work corre…

ebda9f8

…ctly

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Mixed support #2409

Mixed support #2409

Uh oh!

kchobantonov commented Dec 30, 2024 •

edited

Loading

Uh oh!

kchobantonov commented Feb 13, 2025

Uh oh!

sdirix left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kchobantonov commented May 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

sdirix left a comment

Uh oh!

sdirix commented May 21, 2025

Uh oh!

kchobantonov commented May 22, 2025

Uh oh!

Uh oh!

Uh oh!

kchobantonov commented May 22, 2025

Uh oh!

Uh oh!

Mixed support #2409

Are you sure you want to change the base?

Mixed support #2409

Uh oh!

Conversation

kchobantonov commented Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kchobantonov commented Feb 13, 2025

Uh oh!

sdirix left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kchobantonov commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sdirix left a comment

Choose a reason for hiding this comment

Uh oh!

sdirix commented May 21, 2025

Uh oh!

kchobantonov commented May 22, 2025

Uh oh!

Uh oh!

Uh oh!

kchobantonov commented May 22, 2025

Uh oh!

Uh oh!

kchobantonov commented Dec 30, 2024 •

edited

Loading

kchobantonov commented May 8, 2025 •

edited

Loading